Throat cross-sectional area calculation is wrong when accuracy="high"#828
Open
Cesar-Timana wants to merge 1 commit intoPMEAL:devfrom
Open
Throat cross-sectional area calculation is wrong when accuracy="high"#828Cesar-Timana wants to merge 1 commit intoPMEAL:devfrom
accuracy="high"#828Cesar-Timana wants to merge 1 commit intoPMEAL:devfrom
Conversation
… to be with voxel_size = 1
accuracy="high"
Member
|
@jgostick I haven't looked into it, but if the OP’s description is accurate, seems serious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
There is an error in calculating the throat cross-sectional area using the high accuracy method.
The surface area used as input has to be without multiplying by the voxel size.
The following test demonstrates the problem:
When subtracting the surface area of merged regions from the isolated region surface areas, they need to be in the same unit.